refactor: Enforce ServerCallContext in request handling by sokoliva · Pull Request #882 · a2aproject/a2a-python

sokoliva · 2026-03-20T16:57:56Z

Description

Make ServerCallContext a mandatory parameter across all TaskStore implementations (TaskStore interface, DatabaseTaskStore, and InMemoryTaskStore) and update tests.
Make ServerCallContext a mandatory parameter in RequestContext.

Previously, context defaulted to None, which could allow callers to bypass authorization scoping if the context was set to None. By requiring the context, we guarantee that the owner_resolver always has the necessary request context to determine scope boundaries.

Fixes #718 🦕

… 1.0-dev

gemini-code-assist · 2026-03-20T16:58:11Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the TaskStore operations to enforce the use of ServerCallContext as a mandatory parameter. This change significantly enhances the security posture by ensuring that all task-related operations are consistently performed within a defined authorization scope, preventing scenarios where context could be inadvertently omitted. The update promotes a more robust and predictable interaction with task storage mechanisms across the application.

Highlights

Mandatory ServerCallContext: The ServerCallContext parameter is now mandatory across all TaskStore operations, including the TaskStore interface, DatabaseTaskStore, and InMemoryTaskStore implementations. This change removes the possibility of None being passed as a context, ensuring proper authorization scoping.
Enhanced Security and Consistency: By requiring ServerCallContext, the system guarantees that the owner_resolver always has the necessary request context to determine scope boundaries, preventing potential bypasses of authorization scoping that could occur when the context defaulted to None.
Updated Owner Resolver: The OwnerResolver type definition and the resolve_user_scope function in owner_resolver.py have been updated to explicitly require ServerCallContext, removing the None option and the associated None check.
Comprehensive Test Updates: All relevant test cases in test_database_task_store.py, test_inmemory_task_store.py, and test_owner_resolver.py have been updated to reflect the mandatory ServerCallContext parameter, including the introduction of a TEST_CONTEXT constant for consistent testing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-03-20T17:00:33Z

🧪 Code Coverage (vs `1.0-dev`)

⬇️ Download Full Report

	Base	PR	Delta
src/a2a/server/agent_execution/context.py	96.40%	97.22%	🟢 +0.83%
Total	91.47%	91.47%	🟢 +0.01%

Generated by coverage-comment.yml

gemini-code-assist

Code Review

This pull request refactors the TaskStore interface and its implementations (DatabaseTaskStore and InMemoryTaskStore) to enforce the use of ServerCallContext in all operations. This change ensures that the owner_resolver always has the necessary request context for determining scope boundaries, addressing a potential authorization bypass. The tests have also been updated to reflect this change.

tests/server/test_owner_resolver.py

src/a2a/server/tasks/task_manager.py

src/a2a/server/agent_execution/simple_request_context_builder.py

…koliva/a2a-python into Server-Call-Context-Mandatory

src/a2a/server/tasks/task_store.py

src/a2a/server/agent_execution/simple_request_context_builder.py

src/a2a/server/request_handlers/default_request_handler.py

src/a2a/server/agent_execution/context.py

sokoliva · 2026-03-26T11:52:33Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the a2a server and task management components to enforce the mandatory presence of ServerCallContext in various async methods and class constructors. This change removes Optional type hints and associated None checks, simplifying the API and ensuring context availability across TaskStore implementations, RequestContext and TaskManager initialization, and OwnerResolver functions. Corresponding test files have been updated to reflect these changes, including the introduction of a TEST_CONTEXT for consistency. A review comment suggests improving the descriptiveness of a test function name and its docstring in tests/server/test_owner_resolver.py for enhanced code clarity.

tests/server/test_owner_resolver.py

sokoliva added 3 commits March 20, 2026 15:33

Merge branch '1.0-dev' of https://github.com/sokoliva/a2a-python into…

2a8668e

… 1.0-dev

Merge branch '1.0-dev' of https://github.com/sokoliva/a2a-python into…

2f94c4e

… 1.0-dev

feat: Enforce ServerCallContext in all TaskStore operations

72a8a7f

sokoliva requested a review from guglielmo-san March 20, 2026 16:57

sokoliva requested a review from a team as a code owner March 20, 2026 16:57

gemini-code-assist bot reviewed Mar 20, 2026

View reviewed changes

tests/server/test_owner_resolver.py Show resolved Hide resolved

sokoliva and others added 6 commits March 25, 2026 09:16

make ServerCallCOntext mandatory in task manager

93e3e20

Merge branch '1.0-dev' into Server-Call-Context-Mandatory

dc49636

Make ServerCallContext mandatory in CopyingTaskStore

2af7880

format

fbab840

Merge branch '1.0-dev' into Server-Call-Context-Mandatory

cdeb9f9

Merge branch '1.0-dev' into Server-Call-Context-Mandatory

4c9089c

guglielmo-san reviewed Mar 25, 2026

View reviewed changes

src/a2a/server/tasks/task_manager.py Outdated Show resolved Hide resolved

src/a2a/server/agent_execution/simple_request_context_builder.py Outdated Show resolved Hide resolved

sokoliva and others added 5 commits March 26, 2026 09:45

move mandatory parameters to top

3541781

Merge branch 'Server-Call-Context-Mandatory' of https://github.com/so…

ae9cec9

…koliva/a2a-python into Server-Call-Context-Mandatory

Merge branch '1.0-dev' into Server-Call-Context-Mandatory

a21a16a

Make ServerCallContext mandatory in RequestContext

50cf655

Merge branch '1.0-dev' into Server-Call-Context-Mandatory

cf3c9fe

sokoliva changed the title ~~refactor: Enforce ServerCallContext in all TaskStore operations~~ refactor: Enforce ServerCallContext in request handling Mar 26, 2026

sokoliva added 2 commits March 26, 2026 11:09

fix

fddfec7

Merge branch 'Server-Call-Context-Mandatory' of https://github.com/so…

e77f8d9

…koliva/a2a-python into Server-Call-Context-Mandatory

sokoliva requested a review from ishymko March 26, 2026 11:09

ishymko approved these changes Mar 26, 2026

View reviewed changes

make ServerCallCOntext mandatory

4cd6708

gemini-code-assist bot reviewed Mar 26, 2026

View reviewed changes

tests/server/test_owner_resolver.py Outdated Show resolved Hide resolved

sokoliva and others added 2 commits March 26, 2026 11:57

test descr

006cff8

Merge branch '1.0-dev' into Server-Call-Context-Mandatory

b9136dc

sokoliva merged commit c367c83 into a2aproject:1.0-dev Mar 26, 2026
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Enforce ServerCallContext in request handling#882

refactor: Enforce ServerCallContext in request handling#882
sokoliva merged 19 commits intoa2aproject:1.0-devfrom
sokoliva:Server-Call-Context-Mandatory

sokoliva commented Mar 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sokoliva commented Mar 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sokoliva commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist bot commented Mar 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Code Coverage (vs 1.0-dev)

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sokoliva commented Mar 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sokoliva commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

🧪 Code Coverage (vs `1.0-dev`)